Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post AUC beta run dplyr lesson updates #161

Merged
merged 6 commits into from
Jan 13, 2023
Merged

Post AUC beta run dplyr lesson updates #161

merged 6 commits into from
Jan 13, 2023

Conversation

ytakemon
Copy link
Contributor

@ytakemon ytakemon commented Nov 9, 2022

Currently, we filter on INDEL which is a logical column: filter(variants, sample_id == "SRR2584863", (INDEL | QUAL >= 100)) and INDEL is logical. Instead of INDEL, we will now filter on MQ: filter(variants, sample_id == "SRR2584863", (MQ >= 50 | QUAL >= 100))

@ytakemon ytakemon changed the title Switch filtered column to a numeric one. fixes #160 Ongoing dplyr lesson updates Nov 9, 2022
@ytakemon ytakemon marked this pull request as draft November 9, 2022 17:08
@ytakemon
Copy link
Contributor Author

ytakemon commented Nov 9, 2022

Did not know you could "draft" a pull request to indicate it is not yet ready for merging! Very cool!

…nd a tip box was added in the package installation section to advise aginst installing tidyverse when teaching this lesson.
@ytakemon ytakemon marked this pull request as ready for review January 11, 2023 16:45
@ytakemon
Copy link
Contributor Author

ytakemon commented Jan 11, 2023

All issues listed under "Data wrangling and analysis with tidyverse" in our mega issue: #142 have been addressed and are now ready for review. Pinging @JasonJWilliamsNY @naupaka and @poterlowicz-lab (whoever has a moment) to review and merge.

@ytakemon ytakemon changed the title Ongoing dplyr lesson updates Post AUC beta run dplyr lesson updates Jan 11, 2023
Copy link
Member

@naupaka naupaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ytakemon! I spotted one minor thing to fix.

_episodes_rmd/05-dplyr.Rmd Outdated Show resolved Hide resolved
@naupaka naupaka merged commit 07a8a03 into datacarpentry:main Jan 13, 2023
zkamvar pushed a commit that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants