New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improvement of "Request Access" #1228
UI improvement of "Request Access" #1228
Conversation
I like the changes, nice! my only comments would be that the "Request access" button is not necessary for dataset owners. That is in pic 1 for example the dataset owners cannot request access to the database (although it might be argued that they request access for a consumption role; so I am not sure what to think) Same applies for list datasets, when we list datasets we get the list of datasets that we already have access to, which means that the button is uncessary |
@dlpzx originally the "lock" icon was available for everybody, owners as well. I think thats because of the consumption roles or groups, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and looks good!
Feature or Bugfix
Detail
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A
. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
eval
or similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.