New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove --verbose flag from travis-ci #3477
Conversation
LGTM. I'd say this is an improvement over having to download the raw logs on Travis. |
Not sure how I feel about this. OTOH it is nice to see which functions have run in a module (particularly to know if the tests one has added passed or not). OTOH having to look at raw logs hurts usability (especially when linking specific lines for issues to share with others). |
Agreed that there is a tradeoff here. I'm also not sure how I feel about
it. I anticipate that there would be times where people have to turn back
on verbose logs when something hangs and they need to see what, for example.
…On Wed, May 9, 2018 at 11:16 PM, jakirkham ***@***.***> wrote:
Not sure how I feel about this. OTOH it is nice to see which functions
have run in a module (particularly to know if the tests one has added
passed or not). OTOH having to look at raw logs hurts usability (especially
when linking specific lines for issues to share with others).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3477 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASszJ7YJWKgqoRNeXGe2RMJ1rm8N1p9ks5tw7D5gaJpZM4T2eW2>
.
|
@jakirkham any changes in thoughts here? |
When tracking down errors recently (due to the requests bug) I've found myself wishing that verbose wasn't set. I think I always want to look at the error report, and that includes the names of the failed tests. |
Is there some way to get just the names of the modules tested listed instead of every function? That might strike a better balance between keeping the log usable and providing early indication of where failures have occurred. |
|
Ha...very well :) |
So the modules show up in one of the matrix builds, but not all of them. For example, this one is just |
Maybe it changed in pytest versions?
…On Sun, Jun 17, 2018 at 1:33 AM, jakirkham ***@***.***> wrote:
So the modules show up in one of the matrix builds, but not all of them.
For example, this one is just .s
<https://travis-ci.org/dask/dask/jobs/376321534>. Any ideas as to how we
could correct them to also have module names?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3477 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASszE2XIv-ej9UgdnJJkaA_pXC2Nj2nks5t9eo2gaJpZM4T2eW2>
.
|
After fiddling around a little bit, it doesn't seem to matter what the pytest version is (pinned version 3.1.1 vs. the latest release 3.6.1)
But using the pytest-xdist plugin for parallel testing is where the file names go away
Some initial searching didn't turn up a way to have both parallel testing and print the module names without also printing the individual test names. |
Right |
Fixes #3441
I'm not sure that we should do this yet, but I thought I'd put up a PR to see how it looked.