Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --verbose flag from travis-ci #3477

Merged
merged 1 commit into from Jun 13, 2018

Conversation

mrocklin
Copy link
Member

@mrocklin mrocklin commented May 8, 2018

Fixes #3441

I'm not sure that we should do this yet, but I thought I'd put up a PR to see how it looked.

@jrbourbeau
Copy link
Member

LGTM. I'd say this is an improvement over having to download the raw logs on Travis.

@jakirkham
Copy link
Member

Not sure how I feel about this. OTOH it is nice to see which functions have run in a module (particularly to know if the tests one has added passed or not). OTOH having to look at raw logs hurts usability (especially when linking specific lines for issues to share with others).

@mrocklin
Copy link
Member Author

mrocklin commented May 10, 2018 via email

@mrocklin
Copy link
Member Author

@jakirkham any changes in thoughts here?

@mrocklin
Copy link
Member Author

When tracking down errors recently (due to the requests bug) I've found myself wishing that verbose wasn't set. I think I always want to look at the error report, and that includes the names of the failed tests.

@jakirkham
Copy link
Member

Is there some way to get just the names of the modules tested listed instead of every function? That might strike a better balance between keeping the log usable and providing early indication of where failures have occurred.

@mrocklin
Copy link
Member Author

mrocklin@carbon:~/workspace/dask$ py.test  dask 
============================= test session starts ==============================
platform linux -- Python 3.6.4, pytest-3.3.2, py-1.5.2, pluggy-0.6.0
rootdir: /home/mrocklin/workspace/dask, inifile: setup.cfg
plugins: timeout-1.2.1, cov-2.5.1
collected 5442 items / 4 skipped                                               

dask/array/tests/test_array_core.py ...............XX................... [  0%]
........................................................................ [  1%]
.....................x.................................................. [  3%]
..........................................x..s.......................... [  4%]
............ssss........s                                                [  5%]
dask/array/tests/test_chunk.py .....                                     [  5%]
dask/array/tests/test_creation.py .......x.............................. [  5%]
..........................                                                                                  [  6%]
dask/array/tests/test_fft.py ........................................... [  7%]
...............s.s.........s.s.........s.s.s.s.........s.s.s.s.......... [  8%]
........................................................................ [  9%]
........................................................................ [ 11%]
..                                                                                                          [ 11%]
dask/array/tests/test_ghost.py ......................x...                                                   [ 11%]
dask/array/tests/test_gufunc.py ........X.................                                                  [ 12%]
dask/array/tests/test_image.py ...                                                                          [ 12%]
dask/array/tests/test_linalg.py .......................................s [ 12%]
..sssssss............................................................... [ 14%]
........................................................................ [ 15%]
.................                                                                                           [ 15%]
dask/array/tests/test_linearoperator.py .                                                                   [ 15%]

@jakirkham
Copy link
Member

Ha...very well :)

@jakirkham jakirkham merged commit 279fdf7 into dask:master Jun 13, 2018
@jakirkham
Copy link
Member

So the modules show up in one of the matrix builds, but not all of them. For example, this one is just .s. Any ideas as to how we could correct them to also have module names?

@mrocklin
Copy link
Member Author

mrocklin commented Jun 17, 2018 via email

@jrbourbeau
Copy link
Member

After fiddling around a little bit, it doesn't seem to matter what the pytest version is (pinned version 3.1.1 vs. the latest release 3.6.1)

(dask_dev) ➜  dask git:(master) ✗ py.test dask/bytes/
======================================================== test session starts ========================================================
platform darwin -- Python 3.6.4, pytest-3.1.1, py-1.5.3, pluggy-0.4.0
rootdir: /Users/jbourbeau/software/dask, inifile: setup.cfg
collected 82 items / 1 skipped

dask/bytes/tests/test_bytes_utils.py .........
dask/bytes/tests/test_compression.py .....
dask/bytes/tests/test_hdfs.py ssssssssssssssssssssssss
dask/bytes/tests/test_http.py ......s.
dask/bytes/tests/test_local.py .............................s.....s

=============================================== 55 passed, 28 skipped in 3.74 seconds ===============================================

But using the pytest-xdist plugin for parallel testing is where the file names go away

(dask_dev) ➜  dask git:(master) ✗ py.test -n3 dask/bytes/
======================================================== test session starts ========================================================
platform darwin -- Python 3.6.4, pytest-3.1.1, py-1.5.3, pluggy-0.4.0
rootdir: /Users/jbourbeau/software/dask, inifile: setup.cfg
plugins: xdist-1.22.2, forked-0.2
gw0 [82] / gw1 [82] / gw2 [82]
scheduling tests via LoadScheduling
............s.ssssss.sssssssssssssssss..................................s.....ss..
=============================================== 55 passed, 27 skipped in 3.39 seconds ===============================================

Some initial searching didn't turn up a way to have both parallel testing and print the module names without also printing the individual test names.

@jakirkham
Copy link
Member

Right pytest-xdist doesn’t currently have a mechanism to run modules on specific workers. Getting the correct verbosity after that may be possible. Some effective strategies for test distribution are at the end of the issue.

xref: pytest-dev/pytest-xdist#18

@mrocklin mrocklin deleted the travis-not-verbose branch January 3, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants