Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: Merge bitcoin#21563 #5760

Closed
wants to merge 1 commit into from
Closed

Commits on May 4, 2024

  1. Merge bitcoin#21563: net: Restrict period when cs_vNodes mutex is locked

    8c8237a net, refactor: Fix style in CConnman::StopNodes (Hennadii Stepanov)
    229ac18 net: Combine two loops into one, and update comments (Hennadii Stepanov)
    a3d090d net: Restrict period when cs_vNodes mutex is locked (Hennadii Stepanov)
    
    Pull request description:
    
      This PR restricts the period when the `cs_vNodes` mutex is locked, prevents the only case when `cs_vNodes` could be locked before the `::cs_main`.
    
      This change makes the explicit locking of recursive mutexes in the explicit order redundant.
    
    ACKs for top commit:
      jnewbery:
        utACK 8c8237a
      vasild:
        ACK 8c8237a
      ajtowns:
        utACK 8c8237a - logic seems sound
      MarcoFalke:
        review ACK 8c8237a 👢
    
    Tree-SHA512: a8277924339622b188b12d260a100adf5d82781634cf974320cf6007341f946a7ff40351137c2f5369aed0d318f38aac2d32965c9b619432440d722a4e78bb73
    MarcoFalke authored and vijaydasmp committed May 4, 2024
    Configuration menu
    Copy the full SHA
    77b03ca View commit details
    Browse the repository at this point in the history