Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: minimize cs_main locking for governance #5623

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

PastaPastaPasta
Copy link
Member

Issue being fixed or feature implemented

Reduce cs_main locking scope in governance

What was done?

Refactor some stuff around to enable reducing cs_main scope

How Has This Been Tested?

governance functional tests

Breaking Changes

None

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@PastaPastaPasta PastaPastaPasta added this to the 20 milestone Oct 19, 2023
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit scary to touch this code tbh 😄

(re)synced a couple of times on mainnet and testnet, kept testnet node running for a couple of hours and it survived incoming triggers and votes.

ACK

@PastaPastaPasta PastaPastaPasta modified the milestones: 20, 21 Oct 20, 2023
@PastaPastaPasta
Copy link
Member Author

I kinda agree, let's leave this for after we branch off v20

@github-actions
Copy link

This pull request has conflicts, please rebase.

@UdjinM6 UdjinM6 modified the milestones: 21, 20.1 Nov 14, 2023
@PastaPastaPasta
Copy link
Member Author

This is a test comment from github CLI

@UdjinM6 UdjinM6 modified the milestones: 20.1, 21 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants