refactor: use atomic to avoid blocking chainlocks cs on each call to …

…cleanup
dashpay · Feb 24, 2024 · 75d81fd · 75d81fd
1 parent 3fd913a
commit 75d81fd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/llmq/chainlocks.cpp b/src/llmq/chainlocks.cpp
@@ -617,11 +617,8 @@ void CChainLocksHandler::Cleanup()
         return;
     }
 
-    {
-        LOCK(cs);
-        if (GetTimeMillis() - lastCleanupTime < CLEANUP_INTERVAL) {
-            return;
-        }
+    if (GetTimeMillis() - lastCleanupTime < CLEANUP_INTERVAL) {
+        return;
     }
 
     // need mempool.cs due to GetTransaction calls

diff --git a/src/llmq/chainlocks.h b/src/llmq/chainlocks.h
@@ -82,7 +82,7 @@ class CChainLocksHandler : public CRecoveredSigsListener
 
     std::map<uint256, int64_t> seenChainLocks GUARDED_BY(cs);
 
-    int64_t lastCleanupTime GUARDED_BY(cs) {0};
+    std::atomic<int64_t> lastCleanupTime{0};
 
 public:
     explicit CChainLocksHandler(CChainState& chainstate, CConnman& _connman, CMasternodeSync& mn_sync, CQuorumManager& _qman,