Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix persistent term error, refactor version to match broadway #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mithereal
Copy link

this should fix the persistent term error that blows up appsignal when it doesnt exitst, also add ets as an option to persistent term

@josevalim
Copy link
Member

Thank you! Can you please expand on why? :) Why would the persistent term not exist?

@mithereal
Copy link
Author

mithereal commented Feb 10, 2022

maybe its a misconfiguration on my part, but i have a custom producer created, it was working before the 0.7 version, persistant term started throwing in my appsignal, if there is no data in the persistant term table it throws a stack trace, are there any examples on how to acieve this w/o throwing the error. or how to setup a custom prodicer, i cased out the stack trace b/c theres nothing i can find wrong with my producer and it seened like a false positive
also isnt using persistent term less performant than using ets, due to reindexing, thats why i included both ooptions

@josevalim
Copy link
Member

I see. To answer those questions, I will need more information about the error, Erlang version, and how to reproduce it, so we can decide how to move forward. Otherwise we shouldn’t merge this patch. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants