Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup/remove_nightly_from_makefiles_as_it_is_defined_root-dir-wise #238

Conversation

spital
Copy link
Contributor

@spital spital commented Nov 21, 2023

cleanup/remove_nightly_from_makefiles_as_it_is_defined_projectwise (WRONG! update -> root-dir-wise)

Useful, as there was a failure yesterday for ARM / aarch64 build, see

rust-lang/rust#118124

and nightly-2023-11-19 had to be used for make BINS=darkfid

@dark-john
Copy link
Contributor

dark-john commented Nov 21, 2023

Isn't the point of having this setting to be per-project so that there is fine-grained control on a per-project basis?

Probably best that stable is the default and then nightly (or specific nightly as above) is used only where needed, until those fixes hit stable?

See this related issue which @bobsummerwill hit.

What exactly is the makefile pattern for CARGO meant to be doing?

@spital
Copy link
Contributor Author

spital commented Nov 22, 2023

I am not the one to decide what and how neither know answers to your questions.
As of now we need nightly because #![feature(ip)] from lib.rs is not in stable (tried latest 1.74).
I just needed it mainly for the other PR
#239
does not need to be merged in, just use as patch(es)

@spital
Copy link
Contributor Author

spital commented Nov 22, 2023

ah, sorry, my bad
s/projectwise/root-dir-wise

@spital spital changed the title cleanup/remove_nightly_from_makefiles_as_it_is_defined_projectwise cleanup/remove_nightly_from_makefiles_as_it_is_defined_root-dir-wise Nov 22, 2023
@spital spital closed this by deleting the head repository May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants