Merging Pull Requests
Franklin Yu edited this page Apr 15, 2020
·
5 revisions
-
PR should pass tests.
-
Use Squash Commit to merge the PR into a single commit and make the repository history clean.
-
Commit name should be short.
-
If the PR is related to sites fixes, name it like
Fixes for example.org
and describe the changes on the second line, e.g.:Fixes for example.org (#101) - Fixed background here. - Fixes something there. - Fixed #100.
-
If the PR is related to dark sites list, name the merge commit like
example.org is dark (#102)
.
-
-
A single PR should fix one bug, add one feature, or fix problems for one website.
-
If there are source code changes, use
npm run code-style
to see or fix code style issues before merging PR. -
Don't merge PRs that have links to prohibited content, as it can have legal consequences (e.g. distributing links to adult websites is punished in Belarus).
-
Don't commit directly to
master
.