fix: update dynamic theme fixes for GitHub.com #12693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issues with font replacement on GitHub.com dynamic mode and updates the default font-family to match browser.
2 tasks
|
The last commit now also applies |
This fix prevents certain elements from being erroneously monospaced.
as it makes no sense for this portion to be in the middle of unrelated fixes
|
Updated screenshots, ready to merge. Remaining issue (wontfix): Cursor position remains slightly visually broken when editing a file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses various issues caused by dynamic font replacement on GitHub.com.
Editor view
PR view