Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (unified) transaction listing on PayPal.com #12689

Merged
merged 5 commits into from
May 10, 2024

Conversation

oberrich
Copy link
Contributor

@oberrich oberrich commented May 7, 2024

  • Fixes unified transaction view on PayPal.com

image
(before)

image
(after)

@oberrich
Copy link
Contributor Author

oberrich commented May 7, 2024

  • De-uglifies input, see refund view

image
(before)

image
(after)

@alexanderby
Copy link
Member

Could you please share the source CSS colors assigned there (with Dark Reader disabled)? The support for those color mixes was added recently, maybe it should be improved.

@oberrich
Copy link
Contributor Author

oberrich commented May 8, 2024

Dump of styles (devtools)

.tab_container {
    line-height: 1.15;
    -webkit-text-size-adjust: 100%;
    --animate-duration: 1s;
    --animate-delay: 1s;
    --animate-repeat: 1;
    font-family: PayPalSansSmall-Regular,Helvetica Neue,Arial,sans-serif;
    -webkit-font-smoothing: antialiased;
    --darkreader-inline-outline: initial;
    box-sizing: inherit;
    background: var(--sys-background-surface,#fff);
    padding-bottom: 32px;
}
.tab_container:dark-reader {
    color-scheme: dark !important;
    line-height: 1.15;
    -webkit-text-size-adjust: 100%;
    --darkreader-neutral-background: #131516;
    --darkreader-neutral-text: #d8d4cf;
    --darkreader-selection-background: #004daa;
    --darkreader-selection-text: #e8e6e3;
    --animate-duration: 1s;
    --animate-delay: 1s;
    --animate-repeat: 1;
    color: #e8e6e3;
    -webkit-font-smoothing: antialiased;
    --darkreader-inline-outline: initial;
    box-sizing: inherit;
    font-family: Gadugi !important;
    background: var(--sys-background-surface,#fff);
    padding-bottom: 32px;
}

.listing_bg {
    line-height: 1.15;
    -webkit-text-size-adjust: 100%;
    --animate-duration: 1s;
    --animate-delay: 1s;
    --animate-repeat: 1;
    font-family: PayPalSansSmall-Regular,Helvetica Neue,Arial,sans-serif;
    -webkit-font-smoothing: antialiased;
    --darkreader-inline-outline: initial;
    box-sizing: inherit;
    background-color: #faf8f5;
    height: auto;
}
.listing_bg:dark-reader {
    color-scheme: dark !important;
    line-height: 1.15;
    -webkit-text-size-adjust: 100%;
    --darkreader-neutral-background: #131516;
    --darkreader-neutral-text: #d8d4cf;
    --darkreader-selection-background: #004daa;
    --darkreader-selection-text: #e8e6e3;
    --animate-duration: 1s;
    --animate-delay: 1s;
    --animate-repeat: 1;
    color: #e8e6e3;
    -webkit-font-smoothing: antialiased;
    --darkreader-inline-outline: initial;
    box-sizing: inherit;
    font-family: Gadugi !important;
    height: auto;
    background-color: rgb(40, 32, 20);
}

:dark-reader isn't real and merely for distinction

@alexanderby
Copy link
Member

Ah, I thought the color-mix() was used there. You can try using background-color: ${#faf8f5) !important; instead to make it simpler.

src/config/dynamic-theme-fixes.config Outdated Show resolved Hide resolved
src/config/dynamic-theme-fixes.config Outdated Show resolved Hide resolved
@oberrich oberrich requested a review from alexanderby May 10, 2024 09:25
@alexanderby alexanderby merged commit 93832ce into darkreader:main May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants