Fix: escape SVG data URLs #11639
Merged
Fix: escape SVG data URLs #11639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures here seem unrelated. Anything I can do? Surprised the main-merge didn't fix it. |
Closed
|
Thanks for your patience, the PR looks great. I tried to add an integration test for this behavior and stuck for some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
url()directly references an SVG data URL that's not base64-encoded, some characters (<>"'&) need to be escaped before the url is put intoxlink:href. Dark reader was previously not doing it. This PR fixes that.I encountered this as the default "error squiggle" for Codemirror.
Repro at Try Codemirror: Error Diagnostic (wait a second for the output on the right-half of the screen to load in. If your screen is narrow, you'll have to click the "Output" button).
Before PR:
After PR:
