fix: resolve spelling issues #793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sam bacha <sam@manifoldfinance.com>
d-xo
reviewed
Sep 14, 2021
Comment on lines
-116
to
+117
| --data-urlencode "constructorArguements=$constructorArguments" -X POST) | ||
| # NOTE: the Arguements typo is in etherscan's API | ||
| --data-urlencode "constructorArguments=$constructorArguments" -X POST) | ||
| # NOTE: the Arguments typo is in etherscan's API |
There was a problem hiding this comment.
This typo is part of the etherscan api
There was a problem hiding this comment.
Ha wow, just checked hardhat-etherscan to confirm: https://github.com/nomiclabs/hardhat/blob/767f68dee84d6a47cd40153a8ab8552f41a95d5e/packages/hardhat-etherscan/src/etherscan/EtherscanVerifyContractRequest.ts#L14-L16
There was a problem hiding this comment.
and in the official api docs here: https://docs.etherscan.io/api-endpoints/contracts#verify-source-code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sam bacha sam@manifoldfinance.com
Description
fix spelling issues.
Checklist