Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14248 engine: strengthen signals handling #14377

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DAOS-14248 engine: strengthen signals handling #14377

wants to merge 1 commit into from

Conversation

knard-intel
Copy link
Contributor

Description

Revival of the PR #13031 from @bfaccini improving signal handling by the engine:

  • Re-register DAOS handler in case original handler returns.
  • Re-add USR1/USR2 signals to waiting set when triggered.
  • Catch SIGTRAP.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kanard38 @bfaccini @knard-intel
DAOS-14248 engine: strengthen signals handling
0625668 
Re-register DAOS handler in case original handler returns.
Re-add USR1/USR2 signals to waiting set when triggered.
Catch SIGTRAP.

Required-githooks: true

Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@intel.com>
Co-authored-by: Bruno Faccini <bruno.faccini@intel.com>
@knard-intel knard-intel self-assigned this May 15, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'dump of engine's ULTs stacks only works one time'
Status is 'In Review'
Labels: 'scrubbed'
https://daosio.atlassian.net/browse/DAOS-14248

@knard-intel knard-intel requested review from johannlombardi and removed request for johannlombardi May 17, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@knard-intel knard-intel

Labels
None yet
Milestone
No milestone
2 participants
@knard-intel @kanard38