Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15848 test: Add module use to soak job scripts for aurora #14376

Merged
merged 2 commits into from
May 16, 2024
Merged

DAOS-15848 test: Add module use to soak job scripts for aurora #14376

merged 2 commits into from
May 16, 2024

Conversation

mjean308
Copy link
Contributor

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: soak_smoke

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@mjean308
DAOS-15848 test: Add module use to soak job scripts for aurora
142db82 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: soak_smoke

Required-githooks: true

Signed-off-by: Maureen Jean <maureen.jean@intel.com>
@github-actions GitHub Actions
Copy link

Ticket title is 'Soak aurora: module load is failing in job scripts; add "module use"'
Status is 'Open'
Labels: 'daos_ecb_scale,soak'
https://daosio.atlassian.net/browse/DAOS-15848

@mjean308
param name should be mpi_module_use
f70ba1c 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: soak_smoke

Required-githooks: true

Signed-off-by: Maureen Jean <maureen.jean@intel.com>
@mjean308 mjean308 marked this pull request as ready for review May 16, 2024 12:23
@mjean308 mjean308 requested review from a team as code owners May 16, 2024 12:23
daltonbohning
daltonbohning approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I think doing this before calling launch.py should propagate the env

module use ...
launch.py ...

@daltonbohning daltonbohning requested a review from a team May 16, 2024 20:21
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label May 16, 2024
@daltonbohning daltonbohning merged commit a2d0e91 into master May 16, 2024
43 checks passed
@daltonbohning daltonbohning deleted the mjean/DAOS-15848 branch May 16, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesanunez jamesanunez jamesanunez approved these changes

@dinghwah dinghwah dinghwah approved these changes

@shimizukko shimizukko Awaiting requested review from shimizukko

@daltonbohning daltonbohning Awaiting requested review from daltonbohning

@saurabhtandan saurabhtandan Awaiting requested review from saurabhtandan

@rpadma2 rpadma2 Awaiting requested review from rpadma2

@arorasamarth arorasamarth Awaiting requested review from arorasamarth

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
4 participants
@mjean308 @jamesanunez @daltonbohning @dinghwah