Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15828 container: properly init ds_cont_child under check mode #14370

Merged
merged 1 commit into from
May 17, 2024
Merged

DAOS-15828 container: properly init ds_cont_child under check mode #14370

merged 1 commit into from
May 17, 2024

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented May 15, 2024 •
edited

Some DTX related fields in ds_cont_child structure are initialized via dtx_cont_register() that may be skipped under check mode as to some subsequent logic may access uninitialized members. Let's move such fields initialization into cont_child_alloc_ref().

Skip DTX resync and rebuild under check mode.

Features: cat_recov

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Ticket title is 'recovery/container_cleanup.py:ContainerCleanupTest.test_container_label_inconsistency - daos_io core file produced between dmg check commands'
Status is 'In Progress'
Labels: 'ci_impact,daily_test,triaged'
https://daosio.atlassian.net/browse/DAOS-15828

@daosbuild1
Copy link
Collaborator

Test stage Unit Test bdev on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14370/1/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14370/1/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Unit Test bdev with memcheck on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14370/1/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14370/1/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14370/1/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14370/2/execution/node/1301/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14370/2/execution/node/1399/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14370/2/execution/node/1524/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14370/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14370/2/execution/node/1538/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14370/4/execution/node/1568/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-15828 branch 2 times, most recently from ba50802 to a30e475 Compare May 16, 2024 01:44
@Nasf-Fan
DAOS-15828 container: properly init ds_cont_child under check mode
b15b147 
Some DTX related fields in ds_cont_child structure are initialized
via dtx_cont_register() that may be skipped under check mode as to
some subsequent logic may access uninitialized members. Let's move
such fields initialization into cont_child_alloc_ref().

Skip DTX resync and rebuild under check mode.

Features: cat_recov

Signed-off-by: Fan Yong <fan.yong@intel.com>
@Nasf-Fan Nasf-Fan marked this pull request as ready for review May 17, 2024 01:24
@Nasf-Fan Nasf-Fan requested review from a team as code owners May 17, 2024 01:24
@Nasf-Fan Nasf-Fan added the priority Ticket has high priority (automatically managed) label May 17, 2024
@Nasf-Fan
Copy link
Contributor Author

Ping reviewers, the patch is for P1 ticket, thanks!

@Nasf-Fan Nasf-Fan requested a review from a team May 17, 2024 14:07
@gnailzenh gnailzenh merged commit 7bd2ce9 into master May 17, 2024
50 of 51 checks passed
@gnailzenh gnailzenh deleted the Nasf-Fan/DAOS-15828 branch May 17, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiuYawei NiuYawei NiuYawei approved these changes

@gnailzenh gnailzenh gnailzenh approved these changes

@liuxuezhao liuxuezhao Awaiting requested review from liuxuezhao

Assignees
No one assigned
Labels
priority Ticket has high priority (automatically managed)
Milestone
No milestone
4 participants
@Nasf-Fan @daosbuild1 @NiuYawei @gnailzenh