Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15846 common: Use tenv for rsvc_tests #14369

Merged
merged 2 commits into from
May 17, 2024
Merged

DAOS-15846 common: Use tenv for rsvc_tests #14369

merged 2 commits into from
May 17, 2024

Conversation

liw
Copy link
Contributor

@liw liw commented May 15, 2024

Looks rsvc_tests should use tenv instead of unit_env.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Maybe rsvc_tests should use tenv instead of unit_env?

Signed-off-by: Li Wei <wei.g.li@intel.com>
Required-githooks: true
@liw liw requested review from a team as code owners May 15, 2024 00:02
@liw liw marked this pull request as draft May 15, 2024 00:02
Copy link

github-actions bot commented May 15, 2024

Ticket title is 'Failed to build rsvc_tests with Bullseye'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-15846

@liw liw changed the title DAOS-? common: Use tenv for rsvc_tests DAOS-15846 common: Use tenv for rsvc_tests May 15, 2024
@liw liw marked this pull request as ready for review May 15, 2024 05:10
@liw liw requested review from dinghwah and kccain May 15, 2024 05:11
@liw
Copy link
Contributor Author

liw commented May 15, 2024

@daos-stack/dev-build-owners, please review this carefully, for I confess I don't really know what I'm doing here. Thank you.

@liw liw requested a review from a team May 15, 2024 23:59
@liw liw added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label May 16, 2024
@liw
Copy link
Contributor Author

liw commented May 16, 2024

@daos-stack/daos-gatekeeper, since this is a build system fix for a unit test, I assume that it's not too rude to ignore functional testing and CI environment issues?

@mchaarawi
Copy link
Contributor

@daos-stack/daos-gatekeeper, since this is a build system fix for a unit test, I assume that it's not too rude to ignore functional testing and CI environment issues?

yes. you could also use Skip-func-test: true pragma in your commit fwiw.
i still do not see a review from build owners and your comment on the PR mentions that you want to wait for a review from one? @jolivier23 ?
the commit message also needs to be updated as it cannot be a question :-)

@liw liw removed the request for review from a team May 16, 2024 14:20
Skip-func-test: true
Required-githooks: true
@liw liw removed the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label May 16, 2024
@jolivier23 jolivier23 merged commit a88f116 into master May 17, 2024
47 checks passed
@jolivier23 jolivier23 deleted the liw/rsvc_tests branch May 17, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants