Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15830 cq: update pylint to 3.2.0 #14365

Merged
merged 3 commits into from
May 16, 2024
Merged

DAOS-15830 cq: update pylint to 3.2.0 #14365

merged 3 commits into from
May 16, 2024

Conversation

daltonbohning
Copy link
Contributor

@daltonbohning daltonbohning commented May 14, 2024 •
edited

Update pylint from 3.1.1 -> 3.2.0 and resolve new warnings.

Features: BasicCheckoutDm IoSysAdmin EcodOnlineRebuildSingle LargeFileCount SmallFileCount NvmeFault OSAOfflineReintegration pool_create_all DaosContainterSecurityTest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-15830 cq: update pylint to 3.2.0
cdc9536 
Skip-build: true
Skip-test: true

Update pylint from 3.1.1 -> 3.2.0

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning self-assigned this May 14, 2024
@daltonbohning daltonbohning marked this pull request as ready for review May 14, 2024 15:44
@github-actions GitHub Actions
Copy link

Ticket title is 'GHA: update pylint to 3.2.0'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-15830

@daltonbohning daltonbohning marked this pull request as draft May 14, 2024 16:42
@daltonbohning
Copy link
Contributor Author

Sorry, didn't mean to request review yet

@daltonbohning
fix new warnings
8556f86 
Features: BasicCheckoutDm IoSysAdmin EcodOnlineRebuildSingle LargeFileCount SmallFileCount NvmeFault OSAOfflineReintegration pool_create_all DaosContainterSecurityTest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning
more fix
848e871 
Features: BasicCheckoutDm IoSysAdmin EcodOnlineRebuildSingle LargeFileCount SmallFileCount NvmeFault OSAOfflineReintegration pool_create_all DaosContainterSecurityTest
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <dalton.bohning@intel.com>
@daltonbohning daltonbohning marked this pull request as ready for review May 15, 2024 14:47
@daltonbohning daltonbohning requested review from a team as code owners May 15, 2024 14:47
@daltonbohning daltonbohning requested a review from a team May 16, 2024 17:30
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label May 16, 2024
@phender phender merged commit 2d14c91 into master May 16, 2024
51 checks passed
@phender phender deleted the dbohning/daos-15830-2 branch May 16, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimizukko shimizukko shimizukko approved these changes

@dinghwah dinghwah dinghwah approved these changes

@phender phender phender approved these changes

@brianjmurrell brianjmurrell Awaiting requested review from brianjmurrell

@rpadma2 rpadma2 Awaiting requested review from rpadma2

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
4 participants
@daltonbohning @shimizukko @dinghwah @phender