Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15831 client: fix a couple of coverity issues #14364

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

wiliamhuang
Copy link
Contributor

@wiliamhuang wiliamhuang commented May 14, 2024

CID 2555602 and 2555600

Features: pil4dfs

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

CID 2555629, 2555628, 2555602, 2555600

Features: pil4dfs

Required-githooks: true

Signed-off-by: Lei Huang <lei.huang@intel.com>
Copy link

Ticket title is 'Coverity issues, CID 2555629, 2555628, 2555602, 2555600'
Status is 'In Review'
Labels: 'SDL,intercept_lib'
https://daosio.atlassian.net/browse/DAOS-15831

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14364/1/testReport/

Features: pil4dfs

Required-githooks: true

Signed-off-by: Lei Huang <lei.huang@intel.com>
@wiliamhuang wiliamhuang changed the title DAOS-15831 client: fix multiple coverity issues DAOS-15831 client: fix a couple of coverity issues May 16, 2024
@wiliamhuang wiliamhuang marked this pull request as ready for review May 16, 2024 12:59
@wiliamhuang wiliamhuang requested review from a team as code owners May 16, 2024 12:59
@wiliamhuang wiliamhuang requested a review from a team May 17, 2024 12:28
@wiliamhuang
Copy link
Contributor Author

All CI tests passed.

@mchaarawi mchaarawi merged commit a395d83 into master May 17, 2024
52 of 53 checks passed
@mchaarawi mchaarawi deleted the lei/DAOS-15831 branch May 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants