This repository has been archived by the owner on May 27, 2022. It is now read-only.
Adjust the KafkaAppender #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The appender is not starting when the org.kafka is set to DEBUG. It results that the solutions can't start kafka. By checking if the procedure is activated the message can be appended. In other cases the messages are dropped.
|
Will this pull request be accepted? |
| @@ -46,7 +46,10 @@ public KafkaAppender() { | |||
| public void doAppend(E e) { | |||
| ensureDeferredAppends(); | |||
| if (e instanceof ILoggingEvent && ((ILoggingEvent)e).getLoggerName().startsWith(KAFKA_LOGGER_PREFIX)) { | |||
| deferAppend(e); | |||
| //only in case the producer is initialized we are able to send messages. | |||
| if ( (lazyProducer != null ) && lazyProducer.isInitialized() ) { | |||
There was a problem hiding this comment.
I think this condition should rather guard the ensureDeferredAppends();in line 47, not? Buffering up messages in deferAppend while the producer is not initialized is somewhat intentional
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The appender is not starting when the org.kafka is set to DEBUG. It results that the solutions can't start kafka. By checking if the producer is activated the message can be appended. In other cases the messages are dropped.