Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exitCode over process.exit() #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndelangen
Copy link

Hi @danielstjules, thanks for this great package.

I've run into an issue where if I run jsinspect from a node child-process I'm not getting the full stdout output.

Here's a bit of code I was running:

const exec = require('child_process').exec;

const jsinspect = exec(
  "node ./node_modules/.bin/jsinspect --no-literals --min-instances 3 --ignore 'coverage|dist|flow-typed' .",
  {
    maxBuffer: 1024 * 1000,
    encoding: 'utf8',
  },
  (error, stdout) => {
    console.log('stdout', stdout, 'done');
  },
);

When I run this without the change it terminates BEFORE all output is flushed, after the change, all output is there.

It doesn't seem to be consistent across all machines I've tested this on, please don't just close with 'cannot reproduce'. It might need a minimum amount of output and a specific timing for the issue to occur. 27 matches found across 425 files on in my machine 2.49s user 0.43s system 110% cpu 2.644 total.

my system info

macOS 10.12.6 (16G1114)
Model Name:	MacBook Pro
Model Identifier:	MacBookPro11,3
Processor Name:	Intel Core i7
Processor Speed:	2,5 GHz
Number of Processors:	1
Total Number of Cores:	4
L2 Cache (per Core):	256 KB
L3 Cache:	6 MB
Memory:	16 GB

Please let me know what I can do to help / clarify further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant