Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split country codes #996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

molangning
Copy link
Contributor

@molangning molangning commented Apr 5, 2024

In this pr country codes are separated into two files. The original source file is still kept as is.

Copy link
Contributor

@ItsIgnacioPortal ItsIgnacioPortal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@g0tmi1k
Copy link
Collaborator

g0tmi1k commented Apr 5, 2024

Im not sure what value it brings having the same content just in upper and lower case?
That to me, feels overkill?

@g0tmi1k g0tmi1k added enhancement Enhancement proposal Status: Proposal labels Apr 5, 2024
@molangning
Copy link
Contributor Author

@g0tmi1k What I did was to seperate an already existing file into two variants.

There was an environment where an app only takes lowercase for one field and upper case for another, so splitting them makes life easier during fuzzing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement proposal Status: Proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants