Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CICD): Corrected multiple issues in GitHub Actions workflows #1015

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ItsIgnacioPortal
Copy link
Contributor

This pull request fixes the following bugs 🐛 in the Seclists Github Actions:

  • Some wordlists were executing on every single commit instead of only executing when one of the specified paths were modified.
  • The Wordlist Updater - directories GitHub Action had an incorrect job name.
  • The Wordlist Updater - directories GitHub Action had trailing whitespaces in the trigger filepaths.
  • The workflows Wordlist Updater - Trickest wordlists updater and Readme updater - Updates readme with latest stats had missing content: write permissions, which caused these actions to fail when executed in a Seclists fork with the default github-actions account security settings.
  • The workflows Wordlist Updater - directories and Wordlist Updater - words had hard-coded repo URLs, which caused the workflow runs to fail whenever they were executed in a fork of Seclists.

ItsIgnacioPortal and others added 11 commits April 5, 2024 03:45
…ter workflow

Prevents the error 'remote: Permission to USERNAME/SecLists.git denied to github-actions[bot].' when the action is run automatically from a seclists fork that has the default github-actions security settings
…g their path filters.

The list of paths were missing an indentation
Prevents the error 'remote: Permission to USERNAME/SecLists.git denied to github-actions[bot].' when the action is run automatically from a seclists fork that has the default github-actions security settings
@molangning
Copy link
Contributor

Good catch! LGTM

@ItsIgnacioPortal ItsIgnacioPortal changed the title Fixed GitHub Actions workflows fix(CICD): Fixed multiple issues in GitHub Actions workflows Apr 29, 2024
@ItsIgnacioPortal ItsIgnacioPortal changed the title fix(CICD): Fixed multiple issues in GitHub Actions workflows fix(CICD): Corrected multiple issues in GitHub Actions workflows Apr 29, 2024
@ItsIgnacioPortal
Copy link
Contributor Author

ItsIgnacioPortal commented May 10, 2024

Added:

@molangning
Copy link
Contributor

A commit script might be helpful as we are just copy and pasting commit codes

@molangning
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants