Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add excluded option #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add excluded option #39

wants to merge 2 commits into from

Conversation

woolfi182
Copy link

No description provided.

@danielb2
Copy link
Owner

@woolfi182 sorry for the delay. Can we change it to "exclude" as opposed to "excluded" ?

@woolfi182
Copy link
Author

Sure:)

@woolfi182
Copy link
Author

Who will do that? I don't have enough time to do that now. Probably, you have some

README.md Outdated Show resolved Hide resolved
@woolfi182
Copy link
Author

Travis CI cannot pass npm test for node v11 because of the experimental functionality:
globals_queuemicrotask
which is added to global scope, so, lab.js test framework recognize the new variable queuemicrotask as memory leak.
there are two ways to solve that:

  • merge anyway
  • add exclude param to lab invocation
    What do you think about that?

@danielb2
Copy link
Owner

In the package.json, add -I queueMicrotask argument to the lab command. That will solve the issue :)

@danielb2
Copy link
Owner

@woolfi182 I wonder if it will also be valuable to use pattern matching to exclude multiple routes. For example '/assets/*'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants