Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace String Comparisons with Direct Field Comparisons #91

Open
daniel-stoneuk opened this issue Nov 25, 2018 · 0 comments
Open

Replace String Comparisons with Direct Field Comparisons #91

daniel-stoneuk opened this issue Nov 25, 2018 · 0 comments

Comments

@daniel-stoneuk
Copy link
Owner

Difficult to describe this issue clearly. Currently the library generates strings for the items so that DiffUtils can compare and only update items that have visually changed. I got into this habit since I think it's what the DiffUtil documentation uses! As @Robyer mentions in issue #77, this isn't a great way of checking - it would be much more efficient to create equals-like functions.

This optimisation can be applied to both the preferences and the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant