Interactive object count #754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgeGtz
added
new feature
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## interactive-tools #754 +/- ##
=====================================================
- Coverage 100.00% 96.27% -3.73%
=====================================================
Files 158 160 +2
Lines 6944 7389 +445
=====================================================
+ Hits 6944 7114 +170
- Misses 0 275 +275
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DannieSheng
added
ready to review
and removed
work in progress
JorgeGtz
added
ready to review
and removed
work in progress
JorgeGtz
added
work in progress
HaleySchuhl
reviewed
Sep 15, 2021
|
I started reviewing/testing this PR and ran into a few questions:
Updates I plan to make:
|
|
The branch has been fully updated with the 4.x branch, so ready to review/work on again |
|
I can start testing this out after lunch! Can you slack me the test notebook and image you have or is it already on the datasci shared drive? |
|
I only did code updates to fix the conflicts and refactor the tests into modules. Looks like you might have been testing it before, but you might not have gotten to the notebook stage yet? And/or @JorgeGtz might have somthing. I think we were also discussing merging in the |
|
I have a stomata notebook after all. Added this function to the agenda for discussion at dev meeting tomorrow :) |
HaleySchuhl
previously approved these changes
May 5, 2023
HaleySchuhl
added
ready to review
and removed
work in progress
remove self return from .correct method test
finish out code example
updating example to insert images into code chunks
methods felt unreadable so added line to separate
resize
undefined variable name update to defined
var name
testing refactored class methods and such, so pushing to GitHub so the code isn't just locally on my computer like it has been all week.
change default label to label, add label param to init, add label param to save_counts method, wrap logic for only doing fancy label configuration if there is a binary image available to use for create_labels
update save_coords to be a fnx talking to outputs.observations and update old function to be named "print_coords" for to text file
remove extra output
remove coordinate calculation and return
move detect_discs
fix import statement
update logic of test (unfiltered mask has more stuff)
HaleySchuhl
force-pushed
the
interactive-object-count
branch
from
b39eff7
to
e5cb828
Compare
remove device counter and import of params
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added the function detect_discs which helps detecting the pollen grains in the image in #746.
This branch is intended to be updated with the interactive tool for counting objects in an image.
Added the function get_centroids that returns the coordinates of the connected regions in a binary image. The coordinates can be used in the interactive tool to automatically count the objects given by the binary image.
Type of update
Is this a:
Associated issues
Associated with #746
Additional context
The goal is to provide an interactive tool for object counting that can be used with other PlantCV functions to semi-automate the counting.