Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solidity filter #1510

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add solidity filter #1510

wants to merge 18 commits into from

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented May 1, 2024

Describe your changes
A new function that filters objects based on their solidity.

Type of update
Is this a:

  • New feature
  • Work in progress

Associated issues
Merge after #1482

Additional context
Useful in filtering masks of pollen grains.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added new feature New feature ideas and solutions work in progress Mark work in progress labels May 1, 2024
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.3 milestone May 1, 2024
@HaleySchuhl HaleySchuhl self-assigned this May 1, 2024
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation May 1, 2024
Copy link

deepsource-io bot commented May 1, 2024

Here's the code health analysis summary for commits 127c358..ef7a9ab. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage❌ Failure
❗ 1 occurence introduced
🚨 1 failing metric
View Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%
New Branch Coverage100%100%
New Composite Coverage66.7%66.7%
New Line Coverage66.7%, ❌ Below Threshold66.7%, ❌ Below Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature ideas and solutions work in progress Mark work in progress
Projects
PlantCV4
  
Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet

1 participant