Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding camera calibration tutorial #1506

Merged
merged 7 commits into from
May 16, 2024
Merged

Conversation

annacasto
Copy link
Contributor

@annacasto annacasto commented Apr 25, 2024

Describe your changes
Added a tutorial for the checkerboard calibration and camera calibration functions.

Type of update
Is this a:

  • Update to documentation

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@annacasto annacasto added the documentation Documentation issues or features label Apr 25, 2024
Copy link

deepsource-io bot commented Apr 25, 2024

Here's the code health analysis summary for commits 1d16aab..cd47354. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage99.7%99.7%
Line Coverage99.7%99.7%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@k034b363 k034b363 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo that I can see, after the calibration it says "Read in distored image".
Not sure how detailed you want this tutorial to be, but I might suggest including a note about how many squares the checkerboards have to have minimally (I think I remember you mentioning this during lab meeting, but I could be wrong?)

@annacasto
Copy link
Contributor Author

Thanks! I fixed typos and added a line about minimum checkerboard size.

@nfahlgren
Copy link
Member

Looks great, could we add the GitHub and Colab buttons here like we started doing on the newer tutorials? Example here: https://plantcv.readthedocs.io/en/latest/tutorials/kmeans_clustering_tutorial/

@annacasto
Copy link
Contributor Author

Just added those new buttons!

@nfahlgren nfahlgren merged commit 100963c into main May 16, 2024
5 checks passed
@nfahlgren nfahlgren deleted the adding-camera-calibration-tutorial branch May 16, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues or features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants