-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding camera calibration tutorial #1506
Conversation
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one typo that I can see, after the calibration it says "Read in distored image".
Not sure how detailed you want this tutorial to be, but I might suggest including a note about how many squares the checkerboards have to have minimally (I think I remember you mentioning this during lab meeting, but I could be wrong?)
Thanks! I fixed typos and added a line about minimum checkerboard size. |
Looks great, could we add the GitHub and Colab buttons here like we started doing on the newer tutorials? Example here: https://plantcv.readthedocs.io/en/latest/tutorials/kmeans_clustering_tutorial/ |
Just added those new buttons! |
Describe your changes
Added a tutorial for the checkerboard calibration and camera calibration functions.
Type of update
Is this a:
Associated issues
Reference associated issue numbers. Does this pull request close any issues?
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md