Migrate to Vue3 #1377
Draft
Migrate to Vue3 #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgiraud
force-pushed
the
vue3
branch
10 times, most recently
from
10936d5
to
eb9d04e
Compare
Vue 2 -> 3 Vite 3 -> 5 BootstrapVue 2 -> Next datatables bs4 -> 2 Currently we only build js for the home page. Alog the way, we also configure vite/rollup to build chunks for the different libraries.
Using v-if here generates the following error: Unhandled error during execution of scheduler flush This is apparently due to the fact that in some cases the data changes from 'valid data' -> null. Because the sparkline was already rendered, the content of the 'root' element was changed. In this case, the element where to display the 'no data' message being nested in the root element destroyed. The problem is that Vue doesn't know that this element doesn't exist anymore and tries to display it again.
Before: ../dist/highlight.js-uQ0yV3gg.js 898.05 kB │ gzip: 297.18 kB After: ../dist/highlight.js-D4mrhrWl.js 20.76 kB │ gzip: 8.27 kB
Vuedraggable is not compatible with Vue3. We get rid of it for now and will find an alternative later on. Changes were made to DateRangePicker to prevent weird behavior. We now rely on router.isReady or router.afterEach instead of unreliable usage of watch.
A prop is ready only.
Instead of using built css and js files.
Instead of using the built css and js files.
The main idea is to import DataTable instead of relying on an already built library. Selector for the search filter input needs to be adapted due to internal changes in datatables DOM structure. We also change some var to const along the way.
outDir needs to be changed in vite config because otherwise file changes are not detected and HMR cannot work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.