New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show hidden file in folder workspace #366
base: master
Are you sure you want to change the base?
Conversation
KangLin
commented
Apr 13, 2023
•
edited
edited
- Add a filter in the dock of the folder workspace
- Add the title bar
a95f9f5
to
199c871
Compare
- Add set folder as workspace dock set filter
@dail8859 Please review. |
@KangLin Thanks for the PR. So the functionality change of toggling hidden files makes sense and worth exposing that kind of configuration. Testing out the functionality seems to have some issues that it is only trying to show hidden files ( As far as the actual implementation...I like the idea of putting a small extra widget in the title bar but the custom one is a bit confusing with the custom icons and doesn't look like any of the others. And that much extra code doesn't seem to be worth it when it could be easily solved as a checkbox on the preferences dialog. So some options to implement this...
I'm certainly open to other suggestions but the CTitleBar dependency and the non-standard svgs I dont feel is the best direction currently. |
Yes. so that Refactor all.
That's why CTitleBar was added. and refactor all code using QDockwdiget with CTilteBar. Use styles to keep the same.
This feature is also required.
I don't recommend using the way. In that case, there will be fewer work areas.
QWidget's title bar is styled locally system, which may differ from the application's style. QT does not provide a solution to this problem. so that I add CTitleBar to resolve it. |
For now I think the custom title bar is too much customization. Even if all the other dock widgets used it to keep the same look. Not saying something like this might not be useful in the future, but its best to start off simple and add functionality if it is required. Think a simple checkbox in the preferences dialog is a perfect first step. Things can always be adjusted later if there is a solid need. |