Fix bugs that could lead to an unresponsive IDE when working with project files #5444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd some failing tests to ProjectManagerDatabaseTest
MikaelMayer
reviewed
May 15, 2024
| @@ -135,43 +146,49 @@ public class ProjectManagerDatabase : IProjectDatabase { | |||
| lock (myLock) { | |||
| var projectManagerForFile = managersBySourceFile.GetValueOrDefault(uri); | |||
|
|
|||
| if (projectManagerForFile is { IsDisposed: true }) { | |||
| // Defensive coding | |||
| logger.LogError("Found disposed project manager through managersBySourceFile."); | |||
There was a problem hiding this comment.
Good. At least this will avoid a whole class of issues.
MikaelMayer
previously approved these changes
May 15, 2024
MikaelMayer
previously approved these changes
May 16, 2024
MikaelMayer
approved these changes
May 17, 2024
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ProjectManagerDatabase.ProjectFileCacheExpirythat allows test to not wait for the cache to expire, something which is otherwise easily forgottenHow has this been tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.