Fix: Support for user-defined module fmt for all compilers #5441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this fixed the issue you opened, but the underlying problem still persists. Here's another problematic program. module time {}
method Main(){
print "done\n";
}They are all reserved by the GO standard library. I would prefer to merge a more comprehensive fix. |
fabiomadge
reviewed
May 16, 2024
| @@ -686,8 +686,11 @@ private class ClassWriter : IClassWriter { | |||
| } | |||
|
|
|||
| private string FullName(TopLevelDecl decl) { | |||
| var localDefinition = decl.EnclosingModuleDefinition == enclosingModule; | |||
| return IdProtect(localDefinition ? decl.GetCompileName(Options) : decl.GetFullCompileName(Options)); | |||
There was a problem hiding this comment.
I messed with this a little. Maybe you can have double check it.
There was a problem hiding this comment.
I don't know how to evaluate if this is good or not. I'll let the CI test this new behavior.
MikaelMayer
commented
May 16, 2024
Co-authored-by: Fabio Madge <fmadge@amazon.com>
MikaelMayer
commented
May 16, 2024
fabiomadge
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5283
I added the corresponding test.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.