fix: Reject modules that were never verified when building doo files #5170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub-issue-4762 # Conflicts: # Source/DafnyCore/AST/Grammar/Printer.cs
…lready verified, but only what's included by them
keyboardDrummer
approved these changes
Mar 12, 2024
|
Flipped back to draft because I don't think the extra commit is correct, which also means I must be missing a test case somewhere to reject it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4762 by adding a check in the library backend, for any modules that are to be compiled but were not verified and were not already preverified.
Note that it is still possible to build a doo file with
--no-verify, but that option will be recorded in the resulting doo file, so it can never be used unless the consuming context also uses--no-verify.How has this been tested?
Added
doofiles/WithInclude.dfyas the direct regression test, but also addeddoofiles/MergeDooFiles.dfyto exercise the use case of passing doo files as direct sources rather than--library, which this check should not reject.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.