Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix svg syntax for JSX code samples in getting-started with React #3816

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix svg syntax for JSX code samples in getting-started with React #3816

merged 1 commit into from
Jan 29, 2024

Conversation

vimode
Copy link
Contributor

@vimode vimode commented Jan 29, 2024

JSX uses camelCase convention for props names.
Updated stroke-width accordingly in React code samples.

React support for SVG components

mbostock
mbostock approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@mbostock mbostock enabled auto-merge (squash) January 29, 2024 16:30
@mbostock mbostock merged commit 9f9d468 into d3:main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vimode @mbostock