Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration: find better cropping algorithm #124

Open
ieivanov opened this issue Jan 17, 2024 · 0 comments
Open

Registration: find better cropping algorithm #124

ieivanov opened this issue Jan 17, 2024 · 0 comments

Comments

@ieivanov
Copy link
Collaborator

ieivanov commented Jan 17, 2024

LIR is overkill as we are always looking for the overlap between rectangular volumes aligned with the coordinate system axes. LIR allows finding overlaps between polygons of arbitrary shape and it's optimization algorithm is a bit slow for what we need. It still works well, so this is not a blocker, largely a user-experience enhancement.

Maybe try https://github.com/planetlabs/maxrect, https://shapely.readthedocs.io/en/stable/reference/shapely.intersection.html or simple min/max operations on the vertices.

see #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant