Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove protocol element highlight selector tests #29533

Merged
merged 4 commits into from
May 17, 2024

Conversation

ryanthemanuel
Copy link
Collaborator

Additional details

This PR turns off the protocol element highlight selector tests, since that logic is now being surfaced in the cloud for Cypress. We can't remove the (soon to be) dead code that handles the highlight selectors until the DOM sync work is GA though.

Steps to test

n/a

How has the user experience changed?

n/a

PR Tasks

Copy link
Contributor

@mschile mschile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, this is really "removing" the tests not "turning off"

@ryanthemanuel ryanthemanuel merged commit 5a23501 into develop May 17, 2024
83 of 84 checks passed
@ryanthemanuel ryanthemanuel deleted the ryanm/chore/run-tests branch May 17, 2024 15:40
@ryanthemanuel ryanthemanuel changed the title chore: turn off protocol element highlight selector tests chore: remove protocol element highlight selector tests May 17, 2024
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 21, 2024

Released in 13.10.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.10.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants