-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move what-is-circular dep within Cypress repo #29530
Conversation
@@ -0,0 +1,26 @@ | |||
const lodash = require('lodash') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous file here: https://github.com/cypress-io/what-is-circular/blob/master/index.js
@@ -0,0 +1,192 @@ | |||
import { whatIsCircular } from '../../../src/util/what-is-circular' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous test here: https://github.com/cypress-io/what-is-circular/blob/master/test.js
Passing run #55457 ↗︎
Details:
Review all test suite changes for PR #29530 ↗︎ |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
This moves the code from the https://github.com/cypress-io/what-is-circular directly into Cypress.
The https://github.com/cypress-io/what-is-circular repo was a fork of https://github.com/flotwig/what-is-circular which was inspired by https://github.com/tjmehta/is-circular/, but returns the path to the first circular reference found.
I think having this code directly in the repo is beneficial since it's a single file, has tests, and requires no maintenance on our part to run extra CI/release processes in a separate repo if a change is needed. It also deters outside users from including the package, creating an expectation for us to maintain it for them.
Steps to test
Unit tests transferred within utils that should run in the driver tests. Other tests should pass.
How has the user experience changed?
N/A
PR Tasks
cypress-documentation
?type definitions
?