You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oddly enough the @cypress-io/xvfb package used in the CLI is yet another fork of the xvfb package that includes the same changes from https://github.com/cypress-io/node-xvfb. We can't patch package the CLI's xvfb package though since it's used in the CLI.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
This removes the package pointing to our https://github.com/cypress-io/node-xvfb git commit.
I did not see this used any longer in the server package. Where
xvfb
is used in the server package, it is pointing to the cli's xvfb package here: https://github.com/cypress-io/cypress/blob/replace-xvfb-dep/scripts/binary/index.js#L26Oddly enough the
@cypress-io/xvfb
package used in the CLI is yet another fork of thexvfb
package that includes the same changes from https://github.com/cypress-io/node-xvfb. We can't patch package the CLI's xvfb package though since it's used in the CLI.I'll followup by archiving this repo: https://github.com/cypress-io/node-xvfb
Steps to test
No tests fail
How has the user experience changed?
N/A
PR Tasks
cypress-documentation
?type definitions
?