Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove forked xvfb package from server #29511

Merged
merged 6 commits into from
May 15, 2024

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented May 13, 2024

Additional details

This removes the package pointing to our https://github.com/cypress-io/node-xvfb git commit.

I did not see this used any longer in the server package. Where xvfb is used in the server package, it is pointing to the cli's xvfb package here: https://github.com/cypress-io/cypress/blob/replace-xvfb-dep/scripts/binary/index.js#L26

Oddly enough the @cypress-io/xvfb package used in the CLI is yet another fork of the xvfb package that includes the same changes from https://github.com/cypress-io/node-xvfb. We can't patch package the CLI's xvfb package though since it's used in the CLI.

I'll followup by archiving this repo: https://github.com/cypress-io/node-xvfb

Steps to test

No tests fail

How has the user experience changed?

N/A

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this May 13, 2024
Copy link

cypress bot commented May 13, 2024

10 flaky tests on run #55397 ↗︎

0 29194 1328 0 Flakiness 10

Details:

Remove changelog entry
Project: cypress Commit: db22f94d7e
Status: Passed Duration: 20:48 💡
Started: May 14, 2024 3:30 PM Ended: May 14, 2024 3:51 PM
Flakiness  commands/querying/querying.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > throws when alias property isnt a digit or `all` Test Replay
Flakiness  scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
scaffolding component testing > react-vite-ts-unconfigured > scaffolds component testing for React and Vite Test Replay Screenshots
Flakiness  project-setup.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
... > skips the setup page when choosing e2e tests to run Test Replay Screenshots
Flakiness  e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
delayed navigation > errors > redirects to an unexpected cross-origin and calls another command in the cy.origin command Test Replay
Flakiness  commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/55397/overview/56166124-0dfb-4247-a136-649bed463e6b?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > with `resourceType` > can match a proxied image request by resourceType
      </a>
    </td>
    <td>
      
    </td>
  </tr>
  <tr>
    <td colspan="2">
      <a href="https://cloud.cypress.io/projects/ypt4pf/runs/55397/overview/622f7698-6162-46f6-bf4e-cbd27e2777aa?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test">
        ... > stops waiting when an xhr request is canceled
      </a>
    </td>
    <td>
      
    </td>
  </tr></table>

The first 5 flaky specs are shown, see all 8 specs in Cypress Cloud.

Review all test suite changes for PR #29511 ↗︎

@jennifer-shehane jennifer-shehane changed the title dependency: Replace forked xvfb package with xvfb dependency: Remove forked xvfb package from server May 14, 2024
@jennifer-shehane jennifer-shehane changed the title dependency: Remove forked xvfb package from server chore: Remove forked xvfb package from server May 14, 2024
Comment on lines -7 to -8
"clean": "node ./scripts/clean.js",
"prebuild": "yarn postinstall && node ./scripts/start-build.js",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just alphabetizing linting since I touched this file at one point.

@jennifer-shehane jennifer-shehane merged commit d5d4345 into develop May 15, 2024
84 of 86 checks passed
@jennifer-shehane jennifer-shehane deleted the replace-xvfb-dep branch May 15, 2024 16:57
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 21, 2024

Released in 13.10.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.10.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants