[WIP] Units system #160
[WIP] Units system #160
Conversation
|
here is an example of what it would look like: |
|
@gonuke DO you have any though about this ? |
|
Is this still WIP or ready for review? (I can review things on request if they are still WIP, as well - of course) |
thx for offering. |
|
@gonuke, this is probably ready for a first set of review (test are not implemented yet...) the is the light version of the units management. Normalized metrics only depends on their direct parents (i.e. |
| """Checks if metric is already in the registry; adds it if not.""" | ||
| normed_name = "norm_" + metric |
There was a problem hiding this comment.
Can we define a variable to be "norm_" to help guarantee consistency?
| frames = [] | ||
| for dep in m.dependencies: | ||
| frame = self.eval(dep, conds=conds) | ||
| frame = self.eval(dep, conds=conds, normed=False) |
There was a problem hiding this comment.
why do we force this to False here? Maybe a comment?
| @@ -40,7 +41,7 @@ def name(self): | |||
| return self.__class__.__name__ | |||
|
|
|||
|
|
|||
| def _genmetricclass(f, name, depends, scheme): | |||
| def _genmetricclass(f, name, depends, scheme, register): | |||
There was a problem hiding this comment.
Update docstring to describe register
| __doc__ = inspect.getdoc(f) | ||
|
|
||
| def shema(self): |
There was a problem hiding this comment.
Seems like this method name is probably a typo?
And should this return self.schema?
| @@ -105,8 +110,9 @@ def dec(f): | |||
| ('Units', ts.STRING), | |||
| ('Mass', ts.DOUBLE) | |||
| ] | |||
| _matregistry = { "Mass": ["Units", "kg"]} | |||
There was a problem hiding this comment.
I don't think I understand how the registry works?
| return self._schema | ||
| # fill in schema code | ||
| registry = register | ||
| #@property |
| ] | ||
| resources = root_metric(name='Resources', schema=_resource_shema, registry=_resour_registry) | ||
|
|
||
| #del _resour_registry, _resource_shema |
This work aims to allow unit management within Cyclus.