allowing 0 capacity constrain #1544
Open
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like something that could have deep but subtle implications to the functioning of the DRE! I wonder if it is worth considering what this means in the context of the formal definition of the DRE and its constraints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows 0 capacity constrain to be set,
Developer can set a capacity constrain based on a variable without having to check that the constrain they are setting is
>0, also this might be hard to debug as it will only show up at run time in some cases.So I think that instead of throwing an error at runtime, we should allow it, as 0 capacity bid should not impact the DRE solver.
what do you think @gonuke ?