Adding Metadata, and some other change #1509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"data" is plural so there is no "metadatas" |
katyhuff
requested changes
May 31, 2019
src/toolkit/metadatas.h
Outdated
|
|
||
| class UsageMetadatas: public Metadatas { | ||
| public: | ||
| /// The default constructor for Metadatas. |
There was a problem hiding this comment.
Suggested change
| /// The default constructor for Metadatas. | |
| /// The default constructor for UsageMetadatas. |
bam241
force-pushed
the
metadata
branch
2 times, most recently
from
9657680
to
29b5307
Compare
bam241
changed the title
This was referenced Aug 5, 2019
gonuke
reviewed
Sep 7, 2019
src/toolkit/metadata.cycpp.h
Outdated
| @@ -0,0 +1,33 @@ | |||
|
|
|||
| // This includes the required header to add geographic coordinates to a | |||
There was a problem hiding this comment.
Is this a cut & paste error - this comment is about metadata and not geo coordinates
| Metadata::Metadata() {} | ||
| Metadata::~Metadata() {} | ||
|
|
||
| void Metadata::RecordMetadata(Agent* agent) { |
There was a problem hiding this comment.
I'm not sure this is the best function name. Maybe RegisterMetadata? No recording of metadata happens here, this function simply adds it to the output tables to be recorded in the future.
There was a problem hiding this comment.
I suppose you are basing it on the naming of Datum::Record() which is perhaps also poorly named... Although in that case one can interpret it as "start recording"
src/toolkit/metadata.cc
Outdated
| } | ||
|
|
||
| void Metadata::LoadData( | ||
| std::map<std::string, std::map<std::string, double>> datas) { |
src/toolkit/metadata.cc
Outdated
|
|
||
| void Metadata::LoadData( | ||
| std::map<std::string, std::map<std::string, double>> datas) { | ||
| for (auto keyword_datas : datas) { |
katyhuff
approved these changes
Sep 9, 2019
Co-Authored-By: Katy Huff <katyhuff@users.noreply.github.com>
Co-Authored-By: Katy Huff <katyhuff@users.noreply.github.com>
Co-Authored-By: Katy Huff <katyhuff@users.noreply.github.com>
Co-Authored-By: Katy Huff <katyhuff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to allow agent to have metadata.
I inspired myself from the position.cc/.h, and I had some though on how to improve it....
Those inspiration lead to #1510 PR, to change a little bit the way we dealt with position...
Metadatas:Metadata:Allows user to add metadata as it is done in the
pyne::Material, mapping a keyword (string) with almost any value and record them in a Metadata table for the output file that looks like:SimId | AgentId | Keyword | Value | Type, theValuewill be written as astring, theTypecolumn allows to identify it,UsageMetadatas:Yet some kind of metadata (but the more I think about it, the less I believe it should inherit from
Metadata).The UsageMetadata are supposed to record the amount of some usage of any kind per deployment, per decomission, per timestep and per throughput. Each type of usage will have its own keyword (user defined) and to each keyword 4 different usages could be associated.
example of usage: manpower, CO2, water, lollipop, electricity, truck, pretzels,...
the
UsageMetadataTable will look like:SimId | AgentId | Keyword | Value | Usage(I might add a unit here...)For the RecordMetadata and RecordUsageMetadata, I plan to implement it the same way I did for
Position, (already did it for the UsageMetadata...)this will be followed by a PR on the
cycamoreside.To be added to this PR:
The big questions are: