In-situ context/simulation cloning #1243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e current sim's db in situ
Previously, when a context was destructed, it would only delete the root-agents (agents without parents). Later on, in order to enable agents to deploy other agents and then leave the simulation, we changed agents to not destruct their children when they are destructed, but the context was not updated to destruct non-root agents too. This fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for post 1.4, but I just wanted to post it here so I and others don't forget about it. This allows agents to clone the entire state of the context, optionally modify the cloned context, and run the simulation/context to look into the future supporting things like lookahead. It is pretty tricky code and will need a very careful review when the time comes.