Update Position #502
Draft
Update Position #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apparently Position unit tests are missing for |
|
this should not be passing before the corresponding PR is merged in Cyclus (cyclus/cyclus#1510) |
gonuke
reviewed
Nov 27, 2019
| @@ -7,7 +7,7 @@ DeployInst::DeployInst(cyclus::Context* ctx) | |||
| : cyclus::Institution(ctx), | |||
| latitude(0.0), | |||
| longitude(0.0), | |||
| coordinates(latitude, longitude) {} | |||
| coordinates(0,0) {} | |||
There was a problem hiding this comment.
Should this be updated to match the last commit to the cyclus repo where these are initialized in the header/snippet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows cyclus/cyclus#1510.
simplifying the call to toolkit::Position