Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku installation and configuration #769

Closed

Conversation

abernicchia-heroku
Copy link

  • added support to configure and install pgwatch2 to Heroku via Terraform scripts
  • added Heroku-specific Dockerfiles and supporting scripts added. Images are built locally and then pushed to Heroku
  • upgraded Grafana version to 10.4.0 and migrated dashboards to new React-compatible plugins due to Angular deprecation
  • added Heroku installation section to the documentation and README
  • adapted pgwatch2/sql/config_store/config_store.sql and pgwatch2/sql/metric_store/00_schema_base.sql scripts to run on Heroku Postgres

abernicchia-heroku and others added 6 commits April 20, 2024 13:01
New Heroku-specific Dockerfiles and supporting scripts added. Images are built locally and then pushed to Heroku
Upgraded Grafana version to 10.4.0 and migrated dashboards to new React compatible plugins due to Angular deprecation
Added Heroku installation section to the documentation
Adapted pgwatch2/sql/config_store/config_store.sql and pgwatch2/sql/metric_store/00_schema_base.sql scripts to run on Heroku Postgres
…atch2 root folder before executing heroku run
@pashagolub pashagolub self-assigned this Apr 29, 2024
@pashagolub
Copy link
Collaborator

Hello Andrea,

Thanks a lot for your pull request! Unfortunately pgwatch2 is in maintenance mode and we do not accept any new functionality, only bug fixes. Please, consider creating pull request for our WIP pgwatch3 project.

Also, it's better to have a series of smaller patches focused on one specific issue then a big one touching several aspects.

  • added support to configure and install pgwatch2 to Heroku via Terraform scripts

  • added Heroku-specific Dockerfiles and supporting scripts added. Images are built locally and then pushed to Heroku

  • added Heroku installation section to the documentation and README>

This would not be accepted since it is a deployment task and not a part of pgwatch functionality. It's better to have an external repo for this, just like we have an external repo for charts. If you thing Heroku support is perfectly fine for this repository, please, create pull request there.

  • upgraded Grafana version to 10.4.0 and migrated dashboards to new React-compatible plugins due to Angular deprecation

Perfect! Please note, that we recently upgraded dashboards in pgwatch3.

  • adapted pgwatch2/sql/config_store/config_store.sql and pgwatch2/sql/metric_store/00_schema_base.sql scripts to run on Heroku Postgres

Those looks like breaking changes. Schema sql scripts must be compatible with any sql executor, not only psql, thus no psql vars are allowed.

Thanks for your support!

@pashagolub pashagolub closed this Apr 29, 2024
@abernicchia-heroku
Copy link
Author

Hi Pavlo,
thanks for your feedback! At this point, adding that part directly to the new supported release pgwatch3 and maintaining pgwatch2 on a separate fork with the Heroku feature seems better.
It's worth adding a note on pgwatch2 saying that it's in maintenance mode and to look at pgwatch3, I haven't noticed any reference to the new project unfortunately.
Is there an ETA for pgwatch3 being GA?

thanks

@pashagolub
Copy link
Collaborator

Yeah, you're right. We should add a visible badge saying that! My bad!

No deadline for pgwatch3 yet. But we are on the final stage polishing web UI and some non-critical things. UI is the show stopper, frankly speaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants