Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favor 'go install' over 'go get' for installation #166

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

davidhsingyuchen
Copy link

@davidhsingyuchen davidhsingyuchen commented Jan 26, 2022

go get is deprecated in terms of installing executables. $ is removed so that folks can just copy the whole block and run it.

Not opening an issue first because this PR is small. Signed the CLA. Waiting for approval.

@davidhsingyuchen
Copy link
Author

davidhsingyuchen commented Feb 19, 2022

@cweill I can see the signed CLA in my account now, and I'm wondering if you can approve the workflows to be run, thanks!

image

@cweill
Copy link
Owner

cweill commented Feb 19, 2022

Can you please check why the tests are failing? Sorry I don't have much time to investigate myself.

@davidhsingyuchen
Copy link
Author

@cweill Please take a look at #168, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants