Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic Functions Datatables #2280

Closed
wants to merge 31 commits into from

Conversation

Transurgeon
Copy link
Contributor

@Transurgeon Transurgeon commented Oct 31, 2023

Description

Please include a short summary of the change.
This WiP PR is for the update of the atomic functions table. Many new things have been added such as a central functions table located at the top level of the docs, filters for previously existing tables, and new columns that are hidden in the filters.
Other minor details:

  • Reordered some paths in the top level
  • moved images to static folder so global paths can be used (we should probably do the same thing with all the images for the examples)
  • Cleaned up the pages for the respective tables that now use views on the central table.
  • Added clarifications of DCP operations into dropdown.
    The work of this PR can be viewed here along with the previous pages for DCP and DGP functions.
    All feedback is welcome!
    TODOs:
  • Add new column for conic representation
  • Add new filter for conic representation
  • Many styling updates
    Issue link (if applicable):

Type of change

  • New feature (backwards compatible)
  • New feature (breaking API changes)
  • Bug fix
  • Other (Documentation, CI, ...)

Contribution checklist

  • Add our license to new files.
  • Check that your code adheres to our coding style.
  • Write unittests.
  • Run the unittests and check that they’re passing.
  • Run the benchmarks to make sure your change doesn’t introduce a regression.

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ arvoelke
✅ mkoeppe
✅ yuval-nextsilicon
❌ Transurgeon


Transurgeon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Transurgeon Transurgeon marked this pull request as ready for review November 10, 2023 02:16
@Transurgeon
Copy link
Contributor Author

closing as PR is outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants