Implement “excluded” option in vectorize.py #8287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to only support for excluded arrays with |
…ns of different shapes
|
I tried making 2 testcases with the excluded array being different shapes, but I wasn't able to find the problem Do you have a test case in mind that exposes this? |
|
In your two new test cases, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Fixes #8166
TLDR: Implements a option numpy recently introduced in vectorize.py
How: Take the arguments for the vectorized function and copy the “excluded” parameters into a data structure that is the same shape as the non-”excluded” parameters. Pass these modified args into the function generated by ElementwiseKernel like normal.