Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scipy.special.stdtr() API #8234

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add scipy.special.stdtr() API #8234

wants to merge 1 commit into from

Conversation

boku13
Copy link
Contributor

@boku13 boku13 commented Mar 11, 2024

This PR adds the Student's T-Distribution Function from scipy.special.* .

#6324

@kmaehashi kmaehashi self-assigned this Mar 12, 2024
@kmaehashi kmaehashi added cat:feature New features/APIs prio:medium labels Mar 12, 2024
@boku13 boku13 changed the title Add Student's T-Distribution Function add scipy.special.stdtr() API Mar 12, 2024
@boku13
Copy link
Contributor Author

boku13 commented Mar 25, 2024

hello @kmaehashi, is this addition to the codebase welcome?

@kmaehashi
Copy link
Member

Hi, sorry for keep you waited, this looks good to me!

/test mini

@kmaehashi kmaehashi added this to the v14.0.0a1 milestone Mar 27, 2024
@kmaehashi kmaehashi removed this from the v14.0.0a1 milestone Apr 2, 2024
@kmaehashi
Copy link
Member

Hi @boku13, it looks that tests are failing. Could you check the log?

@kmaehashi kmaehashi self-requested a review April 2, 2024 01:15
@boku13
Copy link
Contributor Author

boku13 commented Apr 2, 2024

Sorry for the wait, I was busy with the GSoC proposal.

 	=========================== short test summary info =========================== 	
01:19:01.615934 STDOUT 2832] 	FAILED cupyx_tests\scipy_tests\special_tests\test_ufunc_dispatch.py::TestUfunc::test_dispatch[stdtr] - AssertionError: 	
01:19:01.615934 STDOUT 2832] 	Not equal to tolerance rtol=1e-07, atol=0.0001 	
01:19:01.615934 STDOUT 2832] 		
01:19:01.615934 STDOUT 2832] 	Mismatched elements: 3 / 5 (60%) 	
01:19:01.615934 STDOUT 2832] 	Max absolute difference: 0.0007692 	
01:19:01.615934 STDOUT 2832] 	Max relative difference: 0.00077375 	
01:19:01.615934 STDOUT 2832] 	 x: array([0.99863 , 0.999907, 0.999529, 0.998586, 0.99335 ], dtype=float32) 	
01:19:01.615934 STDOUT 2832] 	 y: array([0.998978, 0.999916, 0.999537, 0.998919, 0.994119], dtype=float32) 	
01:19:01.615934 STDOUT 2832] 	= 1 failed, 108046 passed, 6786 skipped, 677 deselected, 320 xfailed, 2595 warnings in 3645.67s (1:00:45) = 	
01:19:01.616734 STDOUT 2832] 	------------------------------------------------------------------------------------------

Figuring it out right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants