Add NearestNDInterpolator to cupyx.scipy.interpolate #8220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andfoy
changed the title
andfoy
force-pushed
the
add_nearest_nd_interp
branch
2 times, most recently
from
4898caf
to
1e99e6c
Compare
andfoy
force-pushed
the
add_nearest_nd_interp
branch
2 times, most recently
from
8c7acee
to
5f7fffd
Compare
ev-br
reviewed
Apr 3, 2024
andfoy
force-pushed
the
add_nearest_nd_interp
branch
from
5f7fffd
to
2f0ccef
Compare
|
/test mini |
andfoy
force-pushed
the
add_nearest_nd_interp
branch
from
d628c5b
to
6c2f0f3
Compare
|
I can locally confirm that the tests are passing, the CI error is related to the version of SciPy: https://github.com/scipy/scipy/blob/1d3a067c2ccd0a6efddeb3194163aa9a3879d26e/scipy/interpolate/_ndgriddata.py#L101 I'll skip tests for |
|
Is this about |
|
/test mini |
asi1024
approved these changes
May 21, 2024
|
Sorry for my late review. Thanks for your contribution. LGTM! |
|
Thanks @asi1024! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7186
Depends on #8208 for module ordering