Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit the threads to the number of CPUs #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spyamine
Copy link
Contributor

I have only 4 CPU and when I use 8 for bloomberg it just stopped working!! this limitation fixed the problem for me. We can solve the problem more elegantly by putting the limit in the parameters file.

I have only 4 CPU and when I use 8 for bloomberg it just stopped working!! this limitation fixed the problem for me. We can solve the problem more elegantly by putting the limit in the parameters file.
@saeedamen
Copy link
Contributor

Ah, I see. I probably want to leave some flexibility though around this parameter, so people can adjust to what's most appropriate for their machine. The main delay from downloading is the IO blocking, so theoretically you can set a higher number of threads than CPUs (strictly speaking using the thread model in Python is not truly multithreading because still has GIL).

@spyamine
Copy link
Contributor Author

spyamine commented Nov 28, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants